chore: handle lightweight vs full plugin in shell file generation#35
Open
scappuccino-grid wants to merge 1 commit intomainfrom
Open
chore: handle lightweight vs full plugin in shell file generation#35scappuccino-grid wants to merge 1 commit intomainfrom
scappuccino-grid wants to merge 1 commit intomainfrom
Conversation
Distinguish between lightweight (rosetta@rosetta) and full (core@rosetta,
grid@rosetta) plugins when deciding whether to generate shell files in
Phase 2 of init-workspace-flow. Full plugins ship all instructions bundled
so shells are not needed; lightweight plugins require shells to enable
skills, agents, and workflows. When plugin type cannot be detected, ask
the user with an explanation and suggest lightweight (the recommended
install) as the default.
Also fixes inconsistent sentinel phrase used for plugin mode detection
("Rosetta plugin is already active" → "RUNNING AS A PLUGIN").
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
enhancement
Contributor
Rosetta Triage ReviewSummary: This PR improves the Findings:
Suggestions:
Automated triage by Rosetta agent |
isolomatov-gd
requested changes
Mar 25, 2026
Collaborator
isolomatov-gd
left a comment
isolomatov-gd
left a comment
There was a problem hiding this comment.
There is a misunderstanding. Lightweight plugin should not be using instructions/r2/core/rules/plugin-files-mode.md, as such it should not even BE detected as plugin. Moreover lightweight is just a way to simplify two manual actions: installing MCP and adding bootstrap file.
| - Before Phase 1: create `agents/init-workspace-flow-state.md`. | ||
| - Conditional phases: | ||
| - If you have already in context "RUNNING AS A PLUGIN": MUST NOT EXECUTE "shells" phase 2 AND "rules" phase 4 | ||
| - If you have already in context "RUNNING AS A PLUGIN": |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinguish between lightweight (rosetta@rosetta) and full (core@rosetta, grid@rosetta) plugins when deciding whether to generate shell files in Phase 2 of init-workspace-flow. Full plugins ship all instructions bundled so shells are not needed; lightweight plugins require shells to enable skills, agents, and workflows. When plugin type cannot be detected, ask the user with an explanation and suggest lightweight (the recommended install) as the default.
Also fixes inconsistent sentinel phrase used for plugin mode detection ("Rosetta plugin is already active" → "RUNNING AS A PLUGIN").